Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celery Integration #61

Closed
3 tasks
joshuap opened this issue Nov 16, 2020 · 6 comments · Fixed by #124
Closed
3 tasks

Celery Integration #61

joshuap opened this issue Nov 16, 2020 · 6 comments · Fixed by #124

Comments

@joshuap
Copy link
Member

joshuap commented Nov 16, 2020

A customer wasn't sure how to integrate Honeybadger with Django and Celery:

https://docs.celeryproject.org/en/stable/django/

These items are open to anyone who knows how to take this on:

  • Reply with a code sample (or sample app/repo) of how to do it manually
  • Add an official integration, if possible
  • Otherwise, add the manual integration instructions to the Honeybadger docs

Front logo Front conversations

@Kelvin4664
Copy link
Collaborator

So i tried this out and noticed the problem is very similar to that of AWS lambda. i.e honeybadger unable to override sys.excepthook directly. The solution will take similar approach too
Fixing this next..

@joshuap
Copy link
Member Author

joshuap commented Mar 15, 2021

@Kelvin4664 can you close out any issues that are completed in this milestone first? If there are any issue remaining, I'd like to get those finished up so that I can cut a new release with the new AWS Lambda integration.

@Kelvin4664
Copy link
Collaborator

Oh.. sure!
They're all done that's why i picked up this one.
Will close them now.

@joshuap joshuap added this to the 0.6.0 milestone May 7, 2021
@stefanondisponibile
Copy link
Contributor

A way to do this could be using Celery's signals.

@Kelvin4664
Copy link
Collaborator

Celery's signals

Good point @stefanondisponibile
But i fear failure may be critical to the point where failure signals are not sent. What do you think?

@stefanondisponibile
Copy link
Contributor

yeah, good point too @Kelvin4664, I think what you're suggesting may happen.
What you think of this approach instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants