Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore 3.x username suggestion behavior #1272

Closed
a-dows opened this issue Jan 5, 2023 · 4 comments
Closed

Restore 3.x username suggestion behavior #1272

a-dows opened this issue Jan 5, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@a-dows
Copy link

a-dows commented Jan 5, 2023

Pitch

Since updating to v4.0.2+hometown-1.1.0, the web interface's suggested usernames to tag in a post (shown when typing the @ character and waiting) appear to weight follower count, rather than followers/accounts you follow first.

The original sorting should be restored.

Motivation

Accounts you follow are far more likely to be tagged or interacted in a new post than a random high-follower-count account.

@dariusk
Copy link

dariusk commented Jan 5, 2023

Mostly a note for future me, there is more discussion here

https://friend.camp/@darius/109638046110736281

@dariusk dariusk added the bug Something isn't working label Jan 5, 2023
@dariusk dariusk self-assigned this Jan 5, 2023
@dariusk dariusk added this to the v1.1.1 milestone Jan 5, 2023
@dariusk
Copy link

dariusk commented Jan 5, 2023

Looks like I need to revert this change: mastodon#19251

Nope, I just needed to add a ranking order based on following

@dariusk dariusk closed this as completed in 7d12ca1 Jan 5, 2023
@dariusk
Copy link

dariusk commented Jan 5, 2023

Also made a PR on Mastodon mastodon#22956

@dariusk
Copy link

dariusk commented Jan 5, 2023

For the record, after consulting with Eugen, we came up with a better fix: 15e78b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants