Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

hui-image does not handle camera image fetch failure #89

Closed
awarecan opened this issue Jul 8, 2018 · 1 comment
Closed

hui-image does not handle camera image fetch failure #89

awarecan opened this issue Jul 8, 2018 · 1 comment

Comments

@awarecan
Copy link

awarecan commented Jul 8, 2018

Release 0.73.0

hui-image didn't handled exception when fetch camera image failure. Ideally,

For example, if I turn off my Nest Cam, the hui-image will log following error message in console

image

And on the UI the card will collapse to just one row. The top card is the Nest Cam turned off, the bottom one is in normal state (masked most of the image).

image

Ideally, I want to hui-image can handle this exception and fallback to image, so that I can point it to a gray place holder, says camera is off.

home-assistant/core#15051 is loosely depends on this.

@awarecan awarecan changed the title hui-image handle camera image failure hui-image does not handle camera image fetch failure Jul 8, 2018
@balloob
Copy link
Member

balloob commented Jul 9, 2018

We need to include a broken image. Preferably we keep the width and height of the previous image if available but render it with grey background and broken icon in the middle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants