Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zha: Handle both input and output clusters #8410

Merged
merged 1 commit into from
Jul 11, 2017
Merged

zha: Handle both input and output clusters #8410

merged 1 commit into from
Jul 11, 2017

Conversation

rcloran
Copy link
Contributor

@rcloran rcloran commented Jul 8, 2017

bellows 0.3.0 changes the API to have both, renaming the attribute which used
to be for input clusters in the process.

This is in preparation for remotes.

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@rcloran, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @balloob to be potential reviewers.

endpoint.clusters]
in_clusters = [endpoint.in_clusters[c] for c in profile_in_clusters
if c in endpoint.in_clusters]
out_clusters = [endpoint.out_clusters[c] for c in profile_out_clusters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (86 > 79 characters)


if component:
clusters = [endpoint.clusters[c] for c in used_clusters if c in
endpoint.clusters]
in_clusters = [endpoint.in_clusters[c] for c in profile_in_clusters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (83 > 79 characters)

profile_info = zha_const.DEVICE_CLASS[endpoint.profile_id]
component = profile_info[endpoint.device_type]

if ha_const.CONF_TYPE in node_config:
component = node_config[ha_const.CONF_TYPE]
used_clusters = zha_const.COMPONENT_CLUSTERS[component]
profile_in_clusters = zha_const.COMPONENT_CLUSTERS[component][0]
profile_out_clusters = zha_const.COMPONENT_CLUSTERS[component][1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (81 > 79 characters)

profile_info = zha_const.DEVICE_CLASS[endpoint.profile_id]
component = profile_info[endpoint.device_type]

if ha_const.CONF_TYPE in node_config:
component = node_config[ha_const.CONF_TYPE]
used_clusters = zha_const.COMPONENT_CLUSTERS[component]
profile_in_clusters = zha_const.COMPONENT_CLUSTERS[component][0]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

bellows 0.3.0 changes the API to have both, renaming the attribute which used
to be for input clusters in the process.

This is in preparation for remotes.
@balloob balloob merged commit 2f474a0 into home-assistant:dev Jul 11, 2017
@balloob
Copy link
Member

balloob commented Jul 11, 2017

🐬

@balloob balloob mentioned this pull request Jul 13, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
bellows 0.3.0 changes the API to have both, renaming the attribute which used
to be for input clusters in the process.

This is in preparation for remotes.
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants