Add vera power meter. #7134

pavoni · 2017-04-16T12:01:30Z

Description:

Adds a vera power meter as a sensor - with watts as the state - and kwh as an additional attribute.

I don't have one of these - so @danodemano Could you test?

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for `configuration.yaml` (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

mention-bot · 2017-04-16T12:01:31Z

@pavoni, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robjohnson189, @balloob and @fabaff to be potential reviewers.

danodemano · 2017-04-16T13:38:42Z

@pavoni - what do I need to do to test?

pavoni · 2017-04-16T13:52:17Z

@danodemano Have you done any development on HA. If so you just need to checkout my branch (add_vera_power_meter) and run in the normal way.

If not you'll need to set up a dev version of HA as described here (https://home-assistant.io/developers/development_environment/). You can skip the initial stuff about forking the repo and creating a local repo (unless you plan to do some development yourself), and just git clone the master repo - and then git checkout add_vera_power_meter. You should then pick up from PREPARE YOUR ENVIRONMENT.

danodemano · 2017-04-16T13:55:14Z

@pavoni - I have not done any dev work, no. I will give that a shot and let you know.

pavoni · 2017-04-16T14:46:17Z

Sounds like it may be a challenge for you to run this - but if you manage please test that your Power Meters appear - and update correctly.

danodemano · 2017-04-16T14:47:54Z

Nah, dev environment is nearly up and running. setup.py is just installing everything now. Should have some test results for you shortly.

danodemano · 2017-04-16T15:06:36Z

The watts look good:

However it looks like you are pulling watts for kwh as well?

pavoni · 2017-04-16T15:09:35Z

Thanks for testing. Can you git pull and check again.

pavoni · 2017-04-16T15:10:31Z

Those numbers all look pretty big. Should we display in kw?

danodemano · 2017-04-16T15:14:14Z

That's better!

I think watts is fine, it looks nice when you move it to a panel:

Though kw would be fine, I just worry that those with usage <1kw are going to see like .485 kw which isn't really nice either. I don't suppose there is any way to change it dynamically from w to kw if the usage is > 1000w?

houndci-bot · 2017-04-16T15:21:36Z

homeassistant/components/sensor/vera.py

@@ -67,6 +73,12 @@ def update(self):
            self.current_value = self.vera_device.light
        elif self.vera_device.category == "Humidity Sensor":
            self.current_value = self.vera_device.humidity
+        elif self.vera_device.category == "Power meter":
+            power = self.vera_device.power;


statement ends with a semicolon

houndci-bot · 2017-04-16T15:21:36Z

homeassistant/components/sensor/vera.py

@@ -49,6 +49,12 @@ def unit_of_measurement(self):
            return 'lux'
        elif self.vera_device.category == "Humidity Sensor":
            return '%'
+        elif self.vera_device.category == "Power meter":
+            power = self.vera_device.power;


statement ends with a semicolon

pavoni · 2017-04-16T15:22:01Z

Good idea - let's try. Have also rounded the numbers for the main display. So if you can pull and try again.

danodemano · 2017-04-16T15:36:55Z

Hmmm, they don't show up at all now. I see this in the logs:

houndci-bot · 2017-04-16T15:46:14Z

homeassistant/components/sensor/vera.py

@@ -49,6 +49,12 @@ def unit_of_measurement(self):
            return 'lux'
        elif self.vera_device.category == "Humidity Sensor":
            return '%'
+        elif self.vera_device.category == "Power meter":
+            power = convert(self.vera_device.power, float, 0)


undefined name 'convert'

houndci-bot · 2017-04-16T15:46:15Z

homeassistant/components/sensor/vera.py

@@ -49,6 +49,12 @@ def unit_of_measurement(self):
            return 'lux'
        elif self.vera_device.category == "Humidity Sensor":
            return '%'
+        elif self.vera_device.category == "Power meter":
+            power = convert(self.vera_device.power, float, 0)


undefined name 'convert'

pavoni · 2017-04-16T15:48:55Z

Can you try again @danodemano?

danodemano · 2017-04-16T15:51:43Z

NICE!

I'm headed to my folks for Easter but I'll leave it run and check the historical data when I get back in a few hours. Thanks!!

pavoni · 2017-04-16T15:52:25Z

Thanks for your help.

pavoni · 2017-04-16T16:09:09Z

I'm pretty sure switching units will mess up the historic data. So is probably a bad idea.

So we should settle on kW or W. What do you think?

My sense is probably kW - but with 3 rather than 2 digits.

danodemano · 2017-04-16T16:10:32Z

Ahh that's a good point. I would just stick with W then, people can adjust the display using templates if required. HA when directly connected to these meters uses W.

dpembo · 2017-04-16T21:04:05Z

quick test looks good, but I need to switch out a lot of config to be 100% sure it fixes the issues I had around the switch states/etc, especially in automation.

danodemano · 2017-04-16T21:08:18Z

Tried to update and test out the historical data but getting a merge conflict:

balloob

🐬 ok to merge when it's all ok with you @pavoni

pavoni · 2017-04-17T09:37:32Z

@danodemano Did you change anything locally? If not may be the rebase I did to combine the commits.

You could try the suggestions here to overwrite your local with the new remote http://stackoverflow.com/questions/1125968/how-do-i-force-git-pull-to-overwrite-local-files.

Worst case you can delete and re-clone the repo assuming you don't have anything valuable locally.

Will merge when you've tested.

danodemano · 2017-04-17T11:27:39Z

@pavoni - thanks, I was able to fetch and hard reset and am on the current copy of your branch. I have it running now, will let you know how the historical data looks in a few hours. I nuked the database before starting just to make sure it was fresh.

homeassistant added cla-signed integration: vera platform: sensor.vera labels Apr 16, 2017

balloobbot added component platform requirement labels Apr 16, 2017

pavoni mentioned this pull request Apr 16, 2017

Add energy monitor sensor maximvelichko/pyvera#47

Closed

homeassistant added the cla-signed label Apr 16, 2017

houndci-bot reviewed Apr 16, 2017

View reviewed changes

pavoni force-pushed the add_vera_power_meter branch from fe57126 to 3d48d81 Compare April 16, 2017 15:53

homeassistant added the cla-signed label Apr 16, 2017

Add vera power meter.

3d48d81

Use W for power.

6c925f5

balloob approved these changes Apr 16, 2017

View reviewed changes

pvizeli merged commit 1925748 into dev Apr 18, 2017

pavoni deleted the add_vera_power_meter branch April 18, 2017 11:14

balloob mentioned this pull request Apr 21, 2017

0.43 #7197

Merged

home-assistant locked and limited conversation to collaborators Jul 17, 2017

ghost removed the platform: sensor.vera label Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add vera power meter. #7134

Add vera power meter. #7134

pavoni commented Apr 16, 2017

mention-bot commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

houndci-bot Apr 16, 2017

houndci-bot Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

houndci-bot Apr 16, 2017

houndci-bot Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

dpembo commented Apr 16, 2017

danodemano commented Apr 16, 2017

balloob left a comment

pavoni commented Apr 17, 2017

danodemano commented Apr 17, 2017

Add vera power meter. #7134

Add vera power meter. #7134

Conversation

pavoni commented Apr 16, 2017

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

mention-bot commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

houndci-bot Apr 16, 2017

Choose a reason for hiding this comment

houndci-bot Apr 16, 2017

Choose a reason for hiding this comment

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

houndci-bot Apr 16, 2017

Choose a reason for hiding this comment

houndci-bot Apr 16, 2017

Choose a reason for hiding this comment

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

pavoni commented Apr 16, 2017

pavoni commented Apr 16, 2017

danodemano commented Apr 16, 2017

dpembo commented Apr 16, 2017

danodemano commented Apr 16, 2017

balloob left a comment

Choose a reason for hiding this comment

pavoni commented Apr 17, 2017

danodemano commented Apr 17, 2017

Example entry for `configuration.yaml` (if applicable):