Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirement btsmarthub_devicelist==0.1.3 #18961

Merged
merged 5 commits into from
Dec 4, 2018
Merged

Update requirement btsmarthub_devicelist==0.1.3 #18961

merged 5 commits into from
Dec 4, 2018

Conversation

jxwolstenholme
Copy link
Contributor

@jxwolstenholme jxwolstenholme commented Dec 3, 2018

Description:

Updated to require btsmarthub_devicelist 1.1.2 to fix keyerror logs

Related issue (if applicable): fixes issue where unnecessary keyerrors would be displayed in the HA log

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff
Copy link
Member

fabaff commented Dec 3, 2018

A description and a changelog would be nice.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stats test is flaky. Merging.

@MartinHjelmare MartinHjelmare changed the title Added requirement 'btsmarthub_devicelist==0.1.2' Update requirement btsmarthub_devicelist==0.1.3 Dec 4, 2018
@MartinHjelmare MartinHjelmare merged commit 2680bf8 into home-assistant:dev Dec 4, 2018
@ghost ghost removed the in progress label Dec 4, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants