remove the need to have query feature support

[ticapix]

Description:

Some InfluxDB servers don't have /query support feature but are still valid servers for storing data.
Usually those servers are proxies to others timeseries databases.
Exemple of OVH Metrics https://docs.ovh.com/gb/en/metrics/protocol-overview/ where data can be pushed with InfluxDB and query with OpenTSdB/Graphite/Prometeus/...

The proposal still validates the configuration but with less feature requirements on the server side.

Example entry for configuration.yaml (if applicable):

Regular Influxdb yaml configuration.

influxdb:
  host: influxdb.gra1.metrics.ovh.net
  port: 443
  database: homeassistant
  username: token
  password: verylongtoken
  ssl: true
  verify_ssl: true
  max_retries: 3
  default_measurement: state

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[homeassistant]

Hi @ticapix,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[ticapix]

Tests are failing because .write_points is called one additional time on the mock. I need to update the tests too.

[homeassistant]

Hello @ticapix,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• 186d443bed9a3d3b535ea14c41ffb2610613b5e0 - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.
• 505399f12ac3b14eef703d6a20ebdd5586f5275e - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.
• 1c84c2e570809e0f79cdab3bfbd0030d9451a7e7 - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <[email protected]>"
     

     (substituting Author Name and [email protected] for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

[frenck]

I do get why this is done, and done is a nice way 👍
Nevertheless, this drops the check on if the database it writes to exists...

[ticapix]

Hi @frenck,

Thanks for having a look at it.

I did a bit of digging and it should be fine.

By default, Python SDK .write_points uses the database specified during client object creation. (conf[CONF_DB_NAME] in our case)

Python SDK .write_points does a POST /write on the InfluxDB server with the db in the query parameters.

And the InfluxDB endpoint handler "/write" do a check on the DB existence before writing the data, so implicitly, it continues to check that the DB it writes to still exists, even if there is no data to write.

Would that be ok ?

[ticapix]

locally tested with tox -e py36 --develop -- tests/components/test_influxdb.py

[frenck]

@ticapix Aah indeed, correct! Nice thanks! 👍