Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert shopping-list clear to WebSockets #18769

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Nov 29, 2018

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@iantrich
Copy link
Member Author

iantrich commented Nov 29, 2018

@balloob
I'm planning to add the ability to create multiple lists but also was thinking that it would be good to start storing the shopping-list data in the database rather than in a json file. So a couple questions for you:

  1. Is storing to the database rather than a json file worth the trouble?
  2. Which do you think should be done first? (Would still support the current shopping-list panel by having a default list Inbox that would be what is used by the panel.

Thanks.

@balloob
Copy link
Member

balloob commented Nov 29, 2018

Let's not store anything in the database until we have a clear consensus about component data storage. We can't just have 1 component go rogue.

@balloob balloob merged commit a306475 into home-assistant:dev Nov 29, 2018
@ghost ghost removed the in progress label Nov 29, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants