Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirVisual: Show icon for air pollution level, based on its value #18482

Merged
merged 1 commit into from
Nov 15, 2018
Merged

AirVisual: Show icon for air pollution level, based on its value #18482

merged 1 commit into from
Nov 15, 2018

Conversation

leppa
Copy link
Contributor

@leppa leppa commented Nov 15, 2018

Description:

Show excited, happy, neutral, sad, dead emoticon, or biohazard icon, based on air pollution level.

Also, fix a small typo and change air quality index icon to mdi:chart-line. Seems a bit more logical.

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: airvisual
    api_key: YOUR_AIRVISUAL_API_KEY

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@leppa leppa requested a review from bachya as a code owner November 15, 2018 13:05
@ghost ghost added the in progress label Nov 15, 2018
Show excited, happy, neutral, sad, dead emoticon, or biohazard icon,
based on air pollution level.

Also, fix a small typo and change air quality index icon to
`mdi:chart-line`. Seems a bit more logical.
Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Small comment.

homeassistant/components/sensor/airvisual.py Show resolved Hide resolved
@bachya bachya merged commit d1b5bc1 into home-assistant:dev Nov 15, 2018
@ghost ghost removed the in progress label Nov 15, 2018
@bachya
Copy link
Contributor

bachya commented Nov 15, 2018

Thank you! 😎

@leppa leppa deleted the airvisual branch November 15, 2018 17:30
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants