Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan all network interfaces for LIFX bulbs #17530

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

amelchio
Copy link
Contributor

Description:

This uses the new aiolifx.LifxScan.scan() method to discover LIFX bulbs.

While unlikely, bulbs may be seen on multiple network interfaces so I reworked the code to connect on each of them.

For feature parity I also updated the manual configuration schema to allow multiple addresses.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

lifx:
lifx:
  light:
    - server: 10.0.9.149
      broadcast: 10.0.9.255
    - server: 10.0.16.5

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@balloob balloob merged commit 1e44639 into home-assistant:dev Oct 17, 2018
@ghost ghost removed the in progress label Oct 17, 2018
@balloob balloob mentioned this pull request Oct 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
@ghost ghost removed the platform: light.lifx label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants