Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Met weather, refactor and add forecast #17109

Merged
merged 1 commit into from
Oct 7, 2018
Merged

Met weather, refactor and add forecast #17109

merged 1 commit into from
Oct 7, 2018

Conversation

Danielhiversen
Copy link
Member

Description:

Refactor met weather platform and add forecast

Example entry for configuration.yaml (if applicable):

weather:
  - platform: met

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost assigned Danielhiversen Oct 3, 2018
@ghost ghost added the in progress label Oct 3, 2018
forecast for Met.no.
4f3c698 
test met

met no 0.3.0

fix line length

fix line length
MartinHjelmare
MartinHjelmare approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One question.

homeassistant/components/weather/met.py Show resolved Hide resolved
@MartinHjelmare MartinHjelmare merged commit c1ed9ed into dev Oct 7, 2018
@ghost ghost removed the in progress label Oct 7, 2018
@Danielhiversen Danielhiversen deleted the met_weather branch October 7, 2018 19:00
@balloob balloob mentioned this pull request Oct 26, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
cla-signed Hacktoberfest integration: met small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Danielhiversen @MartinHjelmare @bachya @homeassistant