Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts RainMachine to hub model (part 2) #14225

Merged
merged 6 commits into from
May 1, 2018

Conversation

bachya
Copy link
Contributor

@bachya bachya commented May 1, 2018

Description:

#14085 was the first cut at moving RainMachine to a hub/component model (for future functionality). After discussion with @balloob, I want to tweak things so that the rainmachine component forwards discovery of entities to the platforms (which will make configuration easier, as shown below).

BREAKING CHANGE: #14085 (already merged) broke the existing format; this will do so again. If we can merge this before #14085 is released, we will limit to one breaking change (ideal) and can use the message described in that PR.

CC: @MartinHjelmare

Related issue (if applicable): N/A

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5251 (although this related to #14085 originally, since it hasn't been merged, going to hustle and use it for this PR, as well)

Example entry for configuration.yaml (if applicable):

# Bare Configuration:
rainmachine:
  ip_address: 192.168.1.100
  password: abc123

# Configuration of Existing Switch Parameter:
rainmachine:
  ip_address: 192.168.1.100
  password: abc123
  switches:
    zone_run_time: 240

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:
- [ ] New dependencies have been added to the REQUIREMENTS variable (example).
- [ ] New dependencies are only imported inside functions that use them (example).
- [ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
- [ ] New files were added to .coveragerc.

@balloob balloob merged commit 7a05471 into home-assistant:dev May 1, 2018
@bachya bachya deleted the rainmachine-1 branch May 1, 2018 20:11
arsaboo pushed a commit to home-assistant/home-assistant.io that referenced this pull request May 3, 2018
* Adds docs for RainMachine component/hub

* Removing references to remote API

* Collaborator-requested changes

* Adding new info (per home-assistant/core#14225)

* Collaborator-requested changes

* Collaborator-requested changes

* Revert "Collaborator-requested changes"

This reverts commit 34f75ff.

* I think I got it this time...

* Collaborator-requested changes

* Collaborator-requested changes

* Small tweak
@balloob balloob mentioned this pull request May 11, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants