-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update greeclimate to 2.0.0 #121030
Update greeclimate to 2.0.0 #121030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split the PR into two, one for bumping the dependency and one for addressing the bug.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I cannot. The bug was detected and fixed in the API change of the underlying library and forces a fix in the gree integration. Edit: Actually... I can. I'll make the change tomorrow. #121041 |
698f3a9
to
19dca1b
Compare
The failed test appears unrelated, and has happened in a few other cases in the CI history.
Same error is happening here: https://github.com/home-assistant/core/actions/runs/9767393285 |
The tests seem to pass now @cmroche 🥳 Any specific reason this PR is still in draft? ../Frenck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey m8,
There seems to be another merge conflict, could you take a look and rebase this PR onto the latest dev branch?
Thanks 👍
../Frenck
92751cd
to
95549d9
Compare
95549d9
to
c039057
Compare
Left a follow up comment in case you missed it |
Co-authored-by: Joostlek <[email protected]>
Proposed change
Update greeclimate to 2.0.0 https://github.com/cmroche/greeclimate/releases/tag/v2.0.0
Addresses bug where incorrect temperature is reported if the device's reporting units is changed after the device is bound by the integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: