Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update greeclimate to 2.0.0 #121030

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Conversation

cmroche
Copy link
Contributor

@cmroche cmroche commented Jul 2, 2024

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

jpbede
jpbede previously requested changes Jul 2, 2024
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the PR into two, one for bumping the dependency and one for addressing the bug.

@home-assistant home-assistant bot marked this pull request as draft July 2, 2024 19:17
@home-assistant
Copy link

home-assistant bot commented Jul 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cmroche
Copy link
Contributor Author

cmroche commented Jul 2, 2024

Please split the PR into two, one for bumping the dependency and one for addressing the bug.

I cannot. The bug was detected and fixed in the API change of the underlying library and forces a fix in the gree integration.

Edit: Actually... I can. I'll make the change tomorrow. #121041

@cmroche cmroche requested a review from jpbede July 2, 2024 19:44
@cmroche cmroche force-pushed the gree-update-20240701 branch 3 times, most recently from 698f3a9 to 19dca1b Compare July 2, 2024 20:17
@cmroche
Copy link
Contributor Author

cmroche commented Jul 2, 2024

The failed test appears unrelated, and has happened in a few other cases in the CI history.

Run tests Python 3.12 (9): tests/components/conversation/test_init.py#L442
test_http_processing_intent_entity_exposed aiohttp.client_exceptions.ServerDisconnectedError: Server disconnected

Same error is happening here: https://github.com/home-assistant/core/actions/runs/9767393285

@cmroche cmroche marked this pull request as ready for review July 2, 2024 22:08
@cmroche cmroche marked this pull request as draft July 3, 2024 02:05
@frenck
Copy link
Member

frenck commented Jul 6, 2024

The tests seem to pass now @cmroche 🥳

Any specific reason this PR is still in draft?

../Frenck

@cmroche cmroche marked this pull request as ready for review July 6, 2024 18:27
frenck
frenck previously requested changes Jul 7, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey m8,

There seems to be another merge conflict, could you take a look and rebase this PR onto the latest dev branch?

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft July 7, 2024 21:36
@cmroche cmroche force-pushed the gree-update-20240701 branch from 92751cd to 95549d9 Compare July 13, 2024 21:34
@cmroche cmroche force-pushed the gree-update-20240701 branch from 95549d9 to c039057 Compare July 13, 2024 21:49
@cmroche cmroche requested review from frenck July 13, 2024 22:58
@cmroche cmroche marked this pull request as ready for review July 29, 2024 00:07
@cmroche
Copy link
Contributor Author

cmroche commented Aug 3, 2024

@frenck @jpbede Everything ok with you for this change now? I have another update coming to support newer device firmwares, but will need this one merged in first.

Thanks.

@cmroche cmroche requested a review from joostlek August 4, 2024 18:44
@joostlek
Copy link
Member

joostlek commented Aug 4, 2024

Left a follow up comment in case you missed it

homeassistant/components/gree/coordinator.py Outdated Show resolved Hide resolved
tests/components/gree/test_bridge.py Outdated Show resolved Hide resolved
tests/components/gree/test_bridge.py Outdated Show resolved Hide resolved
tests/components/gree/test_climate.py Show resolved Hide resolved
tests/components/gree/test_climate.py Outdated Show resolved Hide resolved
tests/components/gree/test_climate.py Outdated Show resolved Hide resolved
@cmroche cmroche requested a review from joostlek August 5, 2024 00:03
@joostlek joostlek added this to the 2024.8.0 milestone Aug 5, 2024
@joostlek joostlek dismissed stale reviews from frenck and jpbede August 5, 2024 08:56

CI passes

@frenck frenck merged commit 1163cc7 into home-assistant:dev Aug 5, 2024
36 checks passed
frenck pushed a commit that referenced this pull request Aug 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants