Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.6.3 #119742

Merged
merged 28 commits into from
Jun 15, 2024
Merged

2024.6.3 #119742

merged 28 commits into from
Jun 15, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 15, 2024

Release notes adjustments: home-assistant/home-assistant.io#33285

tronikos and others added 27 commits June 15, 2024 18:19
* Include speech_slots in IntentResponse.as_dict

* Populate speech_slots only if available

* fix typo

* Add test

* test all fields

* Fix another test

---------

Co-authored-by: Paulus Schoutsen <[email protected]>
…fallback" (#119526)

* Revert "Revert Use integration fallback configuration for tado water heater fallback (#119466)"

This reverts commit ade936e.

* add decide method for duration

* add repair issue to let users know

* test module for repairs

* Update strings.json

Co-authored-by: Franck Nijhof <[email protected]>

* repair issue should not be persistent

* use issue_registery fixture instead of mocking

* fix comment

* parameterize repair issue created test case

---------

Co-authored-by: Franck Nijhof <[email protected]>
* Bump uiprotect to 1.2.0

changelog: uilibs/uiprotect@v1.1.0...v1.2.0

* bump
* Bump bellows to 0.39.1

* Bump zigpy to 0.64.1
@home-assistant home-assistant bot added the merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. label Jun 15, 2024
@frenck frenck marked this pull request as ready for review June 15, 2024 16:37
@frenck frenck marked this pull request as draft June 15, 2024 16:38
@bdraco
Copy link
Member

bdraco commented Jun 15, 2024

It's a breaking change in 3.12.4 that's causing the issue.

#119454

But we can't update pydantic because .16 is broken #119430

@TheJulianJES
Copy link
Member

TheJulianJES commented Jun 15, 2024

So do we want to cherry-pick the CI pin to Python 3.12.3 into this for now?
Won't fix the Python 3.12.4 incompatibility of course, but that issue isn't new.

@bdraco
Copy link
Member

bdraco commented Jun 15, 2024

I'm testing pydantic/pydantic#9660 to see if it fixes pydantic .16 but it still won't solve this issue right now since we would have to wait for .17 anyways so pinning back to 12.3 makes sense since its already broken anyways

@bdraco
Copy link
Member

bdraco commented Jun 15, 2024

after pydantic/pydantic#9660 and the changes I noted in that PR the tests pass in #119430 and uilibs/uiprotect#39 so hopefully we will get a 1.0.17 soon with that change

@frenck frenck marked this pull request as ready for review June 15, 2024 19:05
@frenck frenck merged commit 394dafd into master Jun 15, 2024
80 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core has-tests merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.