Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporary pin CI to Python 3.12.3" #119454

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jun 12, 2024

Proposed change

Reverts #119261

Original issue has been resolved: actions/setup-python#886

Please note there is also a breaking change between 3.12.3 and 3.12.4 that is affecting pydantic and mashumaro, so needs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet epenet requested a review from a team as a code owner June 12, 2024 06:34
@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Jun 12, 2024
@epenet
Copy link
Contributor Author

epenet commented Jun 12, 2024

It looks like pydantic/mashumaro have incompatibilities with 3.12.4

=========================== short test summary info ============================
ERROR tests/components/discovergy - TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'
ERROR tests/components/github - TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'
ERROR tests/components/nest - TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'

@epenet epenet marked this pull request as ready for review June 21, 2024 08:32
@epenet
Copy link
Contributor Author

epenet commented Jun 21, 2024

CI job "Split tests for full run" has succeded... so we're on the right track :)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Thanks, @epenet 👍

../Frenck

@cdce8p cdce8p merged commit 54d8ce5 into dev Jun 21, 2024
39 checks passed
@cdce8p cdce8p deleted the revert-119261-frenck-2024-0358 branch June 21, 2024 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12.4: Extract downloaded archive; gzip: stdin: not in gzip format
3 participants