Update pydantic to 1.10.17

[cdce8p]

Proposed change

https://github.com/pydantic/pydantic/releases/tag/v1.10.16
pydantic/pydantic@v1.10.15...v1.10.16
https://github.com/pydantic/pydantic/releases/tag/v1.10.17
pydantic/pydantic@v1.10.16...v1.10.17

https://github.com/home-assistant/core/actions/runs/9471830653
https://github.com/home-assistant/core/actions/runs/9599604587
https://wheels.home-assistant.io/musllinux/

Last bump: #116401

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[bdraco]

Looks like all the wheels are working

https://wheels.home-assistant.io/musllinux/

[bdraco]

testing this now

[bdraco]

It looks like there is a breaking change

[bdraco]

The CI is failing as well

[bdraco]

All the tests fail on the uiprotect library as well. It seems private attributes are broken in .16

Downgrading to 1.10.15 and they all pass again.

[bdraco]

I looked at the pydantic docs and it seem like the uiprotect library is doing private attrs correctly but maybe not. Maybe you can spot an error there?

[cdce8p]

All the tests fail on the uiprotect library as well. It seems private attributes are broken in .16

Downgrading to 1.10.15 and they all pass again.

😮‍💨 They don't seem to get it right, do they? The plan as I know it, is to end support for v1 by the end of the month. Would be bad if it's still broken by then. Just wanted to fix a mypy error for the next release 😅

Unfortunately, it's a busy week for me. So I won't have the time to fix it myself.

[cdce8p]

The break is a result of the change here: pydantic/pydantic@5adc381#diff-a20bff027a309d77bb05981c6385eaed08dc7cbce12358c201076a4f1bf04733R13-R16

A minimal repo:

from pydantic import BaseModel

try:
    from pydantic.v1 import BaseModel
    from pydantic.v1.fields import PrivateAttr
except ImportError:
    from pydantic import BaseModel
    from pydantic.fields import PrivateAttr


class Model(BaseModel):
    _val: int | None = PrivateAttr(None)

m = Model()
m._val = 1

from pydantic.v1 import BaseModel doesn't raise an ImportError anymore. However, from pydantic.v1.fields import PrivateAttr seems to be broken. Replacing it with from pydantic.v1 import PrivateAttr works.

[bdraco]

Thanks. Thats a bit annoying. We can change it in uiprotect for sure. I can do that after dinner.

I'm a bit worried it will be an issue for other libraries as well though

[bdraco]

I attempted that change, but it looks like there is more breakage. It seems limited to python 3.12

uilibs/uiprotect#39

[bdraco]

Feel free to push to my PR at uilibs/uiprotect#39. You should have access now

[bdraco]

Might be fixed by pydantic/pydantic#9660

[bdraco]

Is this a breaking change in pydantic?

[cdce8p]

I don't think so. Probably just an issue with pylint as pydantic is compiled. Somehow pylint isn't able to determine the module names properly.

Anyway, ValidationError is importable from both pydantic and pydantic.error_wrappers.

[bdraco]

Verified uiprotect CI is passing with this version as well.