-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppleTV platform stopped working in 0.40.0 (push_updates) #6642
Comments
I'm experiencing the exact same bug. AppleTV component was working fine on 0.39.x with Python 3.6.x but after upgrading to 0.40 I get the same "Not Connected to Apple TV" and error logs as @UltraSub |
Interesting, I have not seen this before. I will have to look into this later today. If I prepare a branch with some additional logging, can any of you try that out for me? Also, it would help a bit if you try to run |
Not yet running a development instance of HA. If you tell me how to test your branch on my production instance I will test, no problem! |
I'm having the same problem, I did run atvremote -v -a push_updates and it shows connection/etc but throws the same error as Ultrasub. |
Runnig with --debug prints one extra output, can you provide what's printed to the terminal? It will help a lot. |
Here it is:
|
There seems to be a bug in atvremote so that |
Hope this helps :) |
Here's a little more data for the pile:
|
That's a lot better, thanks @UltraSub! I still cannot get my head around what is happening here 😮 I have created a branch in the pyatv repo that prints a stacktrace for when an error occurs. This way, maybe I can figure out where this happens. Maybe you can try that out and re-run atvremote? What you should do is basically this.
If you start a new terminal, you must go to pyatv and run the source command again like this:
|
@aaronwolen Interesting, you still have the 400 issue. Perhaps we can troubleshoot that too. |
Will check later tonight and report back @postlund! |
@UltraSub Sure :) |
Couldn't wait, did it on mobile:
And then it just sits there. /edit /edit 2 |
Here's my output using the
|
Humm, this is strange. Because now it seems to work as intended (for both of you). I based this branch of the same commit that is pyatv 0.2.2, which is used by Home Assistant. So this is really weird. Question is if this has something to do which version of aiohttp that is used. I just setup a new environment myself and it pulled in aiohttp 2.0.0rc1 whilst 1.3.4 is pinned by Home Assistant. So, can you try to change aiohttp version and see if he errors appears again:
|
Aha! When downgrading aiohttp I got the error myself:
I found the bug too: aio-libs/aiohttp#1720 |
Downgrading aiohttp definitely seems to have triggered something:
|
Not much we can do, we'll have to wait for a new aiohttp release and make sure an uplift gets included in 0.40.2. Thank you guys for helping me out fixing this! 😄 Also, @aaronwolen, maybe you can keep an eye open for the "400" errors when the new release is out. Maybe it fixes something, who knows. I can't see anything particular strange with in the log you posted above. |
Fixed in aiohttp 1.3.5 which was merged by PR #6660. I think we can close this now. |
Awesome @postlund! |
Same to you @UltraSub! |
Home Assistant release:
0.40.0
Python release:
Python 3.5.2+
Component/platform:
apple_tv
Description of problem:
Upgraded from 38.2 to 40.0 which brought push updates, but now I get "Not connected to Apple TV" in the mediaplayer card and a lot of repeating errors:
An error occurred (restarting): 'NoneType' object has no attribute 'cancel'
Expected:
A working AppleTV component :)
Debug output
Using
atvremote
I can login and work fine with the apple tv's using various commands. Wat doesn't work ispush_updates
command, this produces the following:Since by default the platform now uses push_updates I think this is cause?
The text was updated successfully, but these errors were encountered: