Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiaomi Miio vacuum: change unit_of_measurement for sensors "brush_left", "filter_left", "sensor_dirty_left" #59027

Closed
ildar170975 opened this issue Nov 4, 2021 · 10 comments

Comments

@ildar170975
Copy link

The problem

Starting from 2021.11.0 the following parameters were available from sensors (not from attributes as they were before):

  • main brush left;
  • side brush left;
  • filter left;
  • sensor dirty left.

Earlier these parameters were measured in "hours", now the unit is "seconds" which does not make any sense.
Now I have to use template sensors to represent these parameters in hours.

I propose to change unit to "hours".

What version of Home Assistant Core has the issue?

core-2021.11.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Xiaomi miio

Link to integration documentation on our website

https://www.home-assistant.io/integrations/xiaomi_miio/#xiaomi-mi-robot-vacuum

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this issue as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)


xiaomi_miio documentation
xiaomi_miio source
(message by IssueLinks)

@ildar170975 ildar170975 changed the title Xiaomi Miio vacuum: change unit_of_measurement for sensors Xiaomi Miio vacuum: change unit_of_measurement for sensors "brush_left", "filter_left", "sensor_dirty_left" Nov 4, 2021
@hmmbob
Copy link
Contributor

hmmbob commented Nov 4, 2021

Issue is already raised, and part of architecture discussion. See #58923 (comment) (especially 'edit 2').

@rytilahti
Copy link
Member

Let's keep this issue open until this gets a closure. I personally agree that there should be no need for second granularity on any of the sensors in the integration. Besides the fact that the data is polled less often than that, it also causes (imo) unnecessary state machine updates.

@Draluak
Copy link

Draluak commented Nov 4, 2021

I guess the unit for "last_clean_duration" and "total_duration" shouldn't be seconds either.

@pdobrien3
Copy link

I am on 2021.12.0b0 and sensors still reporting in seconds. I was under the impression that would change? Is this issue being tracked elsewhere?

@zhazell
Copy link

zhazell commented Dec 29, 2021

I'm on 2021.12.7 and same thing. Sensors reporting in seconds

@pdobrien3
Copy link

I really hate to whine. It is not my go to, but this change was just stupid. I am sure there was a reason that made sense somewhere. I just gave up and made template sensors to change all my entities from seconds to hours.

@zhazell
Copy link

zhazell commented Dec 30, 2021

Same. Did that this afternoon until it’s resolved. Back to normal

@YSmetana
Copy link

YSmetana commented Jan 7, 2022

Same boat guys. The seconds are unusable for me.

@rytilahti
Copy link
Member

rytilahti commented Jan 9, 2022

You should create separate template sensors to get the wanted values, see the thread starting from #59092 (comment) - if you are using a some lovelace card to display the data, please report to the card developer that they should use the native_measurement_unit and convert the data for display as they see fit.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants