Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asuswrt for 0.83 gives occasional errors. #18728

Closed
fredrike opened this issue Nov 26, 2018 · 3 comments · Fixed by #18742
Closed

Asuswrt for 0.83 gives occasional errors. #18728

fredrike opened this issue Nov 26, 2018 · 3 comments · Fixed by #18742

Comments

@fredrike
Copy link
Contributor

fredrike commented Nov 26, 2018

**Home Assistant release with the issue: ** 0.83.0b0

Last working Home Assistant release (if known): none, new module

Operating environment (Hass.io/Docker/Windows/etc.): Docker (but not relevant in this case)

Component/platform: asuswrt sensor https://www.home-assistant.io/components/asuswrt/ https://www.home-assistant.io/components/sensor.asuswrt/

Description of problem: The log is filled with errors as the sensor lacks a few checks.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

asuswrt:                                                                                                                                                                                                                     
   host: 192.168.1.1                                                                                                                                                                                                          
   username: !secret asuswrt_user                                                                                                                                                                                             
   port: 22                                                                                                                                                                                                                   
   ssh_key: /config/ssh_key                                                                                                                                                                                                   

Traceback (if applicable):

Update for sensor.asuswrt_upload fails

Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity.py", line 221, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/app/homeassistant/helpers/entity.py", line 347, in async_device_update
    await self.async_update()
  File "/usr/src/app/homeassistant/components/sensor/asuswrt.py", line 126, in async_update
    self._state = round(self._rates[1] / 1000000000, 1)
IndexError: list index out of range

Additional information:

@fredrike
Copy link
Contributor Author

@kennedyshead Perhaps you are missing a test if the data is correct.

@kennedyshead
Copy link
Contributor

This should be in the aioasuswrt rather than in home-assistant

@kennedyshead
Copy link
Contributor

Oh! no my bad! Ofc. it should be fixed in hass

@ghost ghost added the in progress label Nov 27, 2018
@ghost ghost removed the in progress label Nov 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants