Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle access tokens #15963

Closed
balloob opened this issue Aug 13, 2018 · 3 comments · Fixed by #15972
Closed

Better handle access tokens #15963

balloob opened this issue Aug 13, 2018 · 3 comments · Fixed by #15972
Assignees
Labels

Comments

@balloob
Copy link
Member

balloob commented Aug 13, 2018

We don't store access tokens, they are lost every restart of Home Assistant.

I still don't want to store access tokens. They change too often.

Instead I suggest that we make the access tokens JWT tokens signed with the refresh token.

That way we can check validity without having to keep track of them.

@awarecan
Copy link
Contributor

Do we ever need revoke/invalid one or all access_token?

@balloob
Copy link
Member Author

balloob commented Aug 14, 2018

We will add support for revoking refresh tokens.

@balloob balloob self-assigned this Aug 14, 2018
@ghost ghost added the in progress label Aug 14, 2018
@balloob
Copy link
Member Author

balloob commented Aug 14, 2018

Just to expand a bit more on my last comment: revoking a refresh token will revoke all access tokens it ever created.

@ghost ghost removed the in progress label Aug 14, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants