Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two missing strings for translating Mold indicator name in Lokalise #128125

Closed
NoRi2909 opened this issue Oct 10, 2024 · 5 comments · Fixed by #128205
Closed

Two missing strings for translating Mold indicator name in Lokalise #128125

NoRi2909 opened this issue Oct 10, 2024 · 5 comments · Fixed by #128205
Labels
good first issue Issues that are suitable for first-time contributors. integration: mold_indicator translations

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Oct 10, 2024

The problem

The Mold indicator helper name cannot be translated in the Create Helper dialog and the title of the following setup dialog because two strings are not available in Lokalise.

Here two screenshots running the German UI:

Screenshot 2024-10-10 22 42 28

Screenshot 2024-10-10 22 49 06

Guessing from comparing to other Helpers the following two strings are missing in Lokalise:

  component::mold_indicator::title
  component::mold_indicator::config::step::user::title

Those should contain

  Mold Indicator
  Create Mold Indicator

Currently they cannot be found in Lokalise.

Edit: Just nocticed that we have the same bug with History Stats and Random:

 component::history_stats::title
 component::history_stats::config::step::user::title
 component::random::title

Those should contain

 History Stats
 Create History Stats
 Random

But we still have

 component::random::config::step::user::title
 Random helper

which is probably outdated, as Random now forks into Randon binary sensor and Random sensor.

What version of Home Assistant Core has the issue?

core-2024.10.1

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

@mib1185
Copy link
Contributor

mib1185 commented Oct 11, 2024

Hi @NoRi2909
thanks for reporting this. Actually the title strings are missing in strings.json. If you want, feel free to add these missing strings. This would be a good first contribution.
Further if you are comfortable with contributing this, please don't hesitate to go ahead with the missing strings for history_stats and random helpers - any contribution would be highly appreciated 🙂
regards,
Michael

@mib1185 mib1185 added the good first issue Issues that are suitable for first-time contributors. label Oct 11, 2024
@rahulsamant37

This comment was marked as off-topic.

@Shubham-Goswami06
Copy link

fixed it check PR #128854 and please give me feedback if I did something wrong and how can I improve it this is my first time

@NoRi2909
Copy link
Contributor Author

@Shubham-Goswami06 Great, the string just landed in Lokalise and is already translated into German. 😃

If you like to go after a few more similar bugs, have a look at #128367 where we already got the OK to move ahead. And #128341 with a simple typo.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Issues that are suitable for first-time contributors. integration: mold_indicator translations
Projects
None yet
4 participants