Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAQI - Can't add manually stations with ID above 9999, validation issue. #103165

Closed
alekdebski opened this issue Nov 1, 2023 · 2 comments · Fixed by #103166
Closed

WAQI - Can't add manually stations with ID above 9999, validation issue. #103165

alekdebski opened this issue Nov 1, 2023 · 2 comments · Fixed by #103166
Assignees

Comments

@alekdebski
Copy link

alekdebski commented Nov 1, 2023

The problem

Custom station pick does not accept values above 9999.
Throwing

Issue very easy to reproduce:

  1. Set up integration,
  2. Get API key,
  3. Try to choose station by providing number,
  4. Try values above 9999, for example station 10002 or 56000,
  5. You will see unexpected error.

What version of Home Assistant Core has the issue?

core-2023.10.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

WAQI

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@alekdebski alekdebski changed the title Can't add manually stations with ID above 9999, validation issue. WAQI - Can't add manually stations with ID above 9999, validation issue. Nov 1, 2023
@home-assistant
Copy link

home-assistant bot commented Nov 1, 2023

Hey there @joostlek, mind taking a look at this issue as it has been labeled with an integration (waqi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of waqi can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign waqi Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


waqi documentation
waqi source
(message by IssueLinks)

@joostlek
Copy link
Member

joostlek commented Nov 1, 2023

I don't think its because of the high number, its missing data from waqi. Let me try to see whats going on

@joostlek joostlek mentioned this issue Nov 1, 2023
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants