Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelled "Set up" in settings #4195

Closed
adam5532 opened this issue Feb 8, 2024 · 5 comments · Fixed by #4196
Closed

Misspelled "Set up" in settings #4195

adam5532 opened this issue Feb 8, 2024 · 5 comments · Fixed by #4196
Labels
bug Something isn't working

Comments

@adam5532
Copy link
Contributor

adam5532 commented Feb 8, 2024

Home Assistant Android app version(s):
2024.1.5-full

Android version(s):
14
Device model(s):
Galaxy S21 5G
Home Assistant version:

Last working Home Assistant release (if known):

Description of problem, include YAML if issue is related to notifications:
In Companion App settings, NFC Tags and Manage Tiles sections, "Set up" is misspelled as "Setup". "Setup" is a noun and can not be used here. The compound verb is spelled "Set up" (two words).

Companion App Logs:


Screenshot or video of problem:

Additional information:

@adam5532 adam5532 added the bug Something isn't working label Feb 8, 2024
@dshokouhi
Copy link
Member

all of the app strings in English are managed in

https://github.com/home-assistant/android/blob/master/common/src/main/res/values/strings.xml

we have setup in a few different locations

  • manage tiles
  • NFC
  • last notification sensor description
  • last removed notification sensor description
  • when a quick setting tile was added but not configured

are all of those incorrect?

feel free to make edits to that file directly

@adam5532
Copy link
Contributor Author

adam5532 commented Feb 9, 2024

Hi Daniel,

are all of those incorrect?
I will check when I edit the file.

feel free to make edits to that file directly

When I click "Edit in place", it says:
"You need to fork this repository to propose changes.
Sorry, you’re not able to edit this repository directly—you need to fork it and propose your changes from there instead."

I am signed into my GitHub account.
Please let me know how to proceed.

Thanks!
Adam

@dshokouhi
Copy link
Member

so github should walk you through the steps but yes you would first fork the repository then when making changes it will ask to create a "patch" branch where the edits will be. From there it will ask to submit a pull request where we will review.

@adam5532
Copy link
Contributor Author

adam5532 commented Feb 9, 2024

Hi Daniel,
I'm quite an experienced programmer, but don't have much experience with GitHub. I find it exceedingly unintuitive and frustrating. I've forked it, and see that I can now edit and commit changes when ready, but I can't find the most basic thing: searching the file text for a string. The search window at the top wants to find repositories and not strings. Chrome's "find in page" doesn't seem to search the edit window. If I open it in github.dev instead, I can sort of search for strings, except that it returns results for all the files in the repository, and there's now no "Commit changes" button. Your help is appreciated!
Thanks,
Adam

@dshokouhi
Copy link
Member

when you are in the editor, make sure to click in the edit field and then you can press "ctrl+f" and the editor search prompt will show up, it does look a bit hidden on first glance

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants