Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fetch from the web during build time #1819

Open
FRidh opened this issue Nov 30, 2020 · 0 comments
Open

Don't fetch from the web during build time #1819

FRidh opened this issue Nov 30, 2020 · 0 comments
Labels
type: discussion Requiring community discussion
Milestone

Comments

@FRidh
Copy link

FRidh commented Nov 30, 2020

ALL software version info

  • Panel 10.2
  • NixOS

Description of expected behavior and the observed behavior

Upgrading to panel version 10.2 I noticed it attemps to download files. This was introduced in #1651.

Setuptools allows writing arbitrary Python code, however, the Python packaging world is finally moving away from this for many good reasons. One of the reasons here is that a build should not fetch itself from the web.

Building inside a container without network now fails. We do this in Nixpkgs for purity reasons.

I strongly suggest looking for a different solution. A possible way could be having a separate git repo with the models, and including it as a submodule, if your goal is to avoid bloat in a repo. Or even as a separate Python package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Requiring community discussion
Projects
None yet
Development

No branches or pull requests

2 participants