add globals to app_spec #796
Conversation
|
well, something in the build on circle CI causes it to come out with a different dna hash, then on my machine... |
|
hmmm dna address still coming back different that what happens when I run on my machine. I'm using the nix-shell command |
|
@zippy, I'm not sure but I guess any discrepancy in the toolchain will result in a different binary output. Maybe the hash should not be hardcoded in the test but rather taken from the DNA file under test? |
| @@ -76,7 +74,8 @@ pub mod tests { | |||
|
|
|||
| assert_eq!(globals.dna_name, "TestApp"); | |||
| // TODO #233 - Implement agent address | |||
There was a problem hiding this comment.
| // TODO #233 - Implement agent address | |
| }; | ||
|
|
||
| let dna = maybe_dna.or_else(|e: String| { | ||
| let error_string = cx.string(format!("unable to call zome function: {:?}", &e)); |
There was a problem hiding this comment.
unable to call zome function?
…ochain-rust into globals-in-appspec
There was a problem hiding this comment.
Maybe just make sure that #233 ticket gets closed too. Awesome to have this in!
we have: We can access the app dna hash in the zome
and also
runtime globals are actually correct values (See invoke_init_globals) in the SoA.
as if they aren't implemented.
It actually looks to me like they are, at least partially, working. As these app_spec tests seem to show.
Feedback?