This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Prevent silent (ish) failure of agent validation #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prevents confusion between validation failures and actual errors
willemolding
requested review from
lucksus,
zippy,
freesig and
StaticallyTypedAnxiety
crates/core_types/src/dna/mod.rs
Outdated
| }) | ||
| .filter_map(|r| match r { | ||
| Ok(_) => None, | ||
| Err(e) => Some(e.to_owned()), |
There was a problem hiding this comment.
r.err() will return an option so we could probably change this to filter_map(|r| r.err())
crates/core_types/src/dna/mod.rs
Outdated
| Err(e) => Some(e.to_owned()), | ||
| }) | ||
| .collect(); | ||
| if errors.len() == 0 { |
There was a problem hiding this comment.
errors.is_empty()
StaticallyTypedAnxiety
approved these changes
Nov 7, 2019
lucksus
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1824
Issue description
This issue stemmed from artifacts in the .dna.json file. As the
validate_agentcallback must be run for all zomes in a DNA it iterates over everything in thezomesfield. If there is a __META.. field in the zome object it will include this and try to use it to run the validation callback.Instead of producing a proper error it just assumed the failure of validation of an agent and this is why links could not be retrieved off their address.
Fix
This adds several fixes to prevent this bug
Validation callbacks will explicitly panic if an unknown error occurs. This seems more appropriate than assuming all errors mean a validation failure (in this case it is a corrupt DNA failure)
Adds a check on loading a .dna.json file that all the
codefields in zomes contain some code (in future check they all have the required callbacks)Update the
hc packagetool to not dump __META stuff in json by default.--strip-metaflag is now--include-meta.PR summary
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation