This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Update test agent config with correct public_address #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
requested review from
zippy,
StaticallyTypedAnxiety and
willemolding
StaticallyTypedAnxiety
approved these changes
Sep 3, 2019
zippy
approved these changes
Sep 3, 2019
| @@ -7,7 +7,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| ### Added | |||
|
|
|||
| * Adds EncryptedSeed and seed.encrypt() allow for easy passphrase encrypting/decrypting of any of the existing seed types. Adds the MnemonicableSeed trait allows seeds to be converted to/from BIP39 mnemonics. [#1687](https://github.com/holochain/holochain-rust/pull/1687) | |||
| - added nix for `hc-conductor-install` and `hc-conductor-uninstall` based on `cargo` | |||
| * added nix for `hc-conductor-install` and `hc-conductor-uninstall` based on `cargo` | |||
There was a problem hiding this comment.
looks like this got added back in incorrectly.
There was a problem hiding this comment.
I just changed the - to * for consistency
willemolding
approved these changes
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Modify the config so that the public_address is correct. When loading from config, the public_address is simply ignored for test_agents, as it is generated from the agent's name instead of read from a physical keyfile. However,
admin/agent/listuses the value from the config, which is, in general, wrong. So, this makes the value in the config right so that the admin method can report the right value.changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)