Link optimization #1607
Link optimization #1607
Conversation
…holochain-rust into link-optimization
…holochain-rust into link-optimization
|
Fixing app_spec after merge Edit : Fixed |
| @@ -99,6 +99,12 @@ pub async fn hold_link_workflow( | |||
| // 3. If valid store the entry in the local DHT shard | |||
| await!(add_link(&link_add, &context))?; | |||
| context.log(format!("debug/workflow/hold_link: added! {:?}", link)); | |||
|
|
|||
| //4. store link_add Entry | |||
| await!(hold_entry_workflow(&entry_with_header, context.clone()))?; | |||
There was a problem hiding this comment.
Just to clarify does this now mean that the nodes that hold the base also hold the link meta on the base and the link_add entry?
There was a problem hiding this comment.
Yes.
For the link meta => so that we can get the headers
Link Add Entry => So that we can get the target
There was a problem hiding this comment.
I think this seems ok. It does mean that LinkAdd entries will be twice as dense in the DHT space when there is sharding so I guess this is a storage vs. retrieval time tradeoff.
| #[derive(Debug, Serialize, Deserialize, PartialEq, DefaultJson, Clone)] | ||
| pub struct GetLinkData | ||
| { | ||
| pub address : Address, |
There was a problem hiding this comment.
is the the link base or the address of the LinkAdd?
There was a problem hiding this comment.
address of the link_add :) will be used to filter for the remove_link
Co-Authored-By: Nicolas Luck <[email protected]>
Co-Authored-By: Nicolas Luck <[email protected]>
PR summary
Leveraging some of the link processing to the DHT node
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)