-
Notifications
You must be signed in to change notification settings - Fork 267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The tests that are failing are these ones
Interestingly these are tests I have had issues with before when I didn't give the test instance a unique network name test_instance(dna, netname)
^^^^^^^^ - This was not unique In that case they failed with the exact same timeout errors. I am wondering if the network name is no longer being handled correctly resulting in conflicting in-memory networks. |
That's exactly what I thought, and went and traced through the netname stuff but couldn't find things out of place. An now it looks like things pass. I can't see how your commit could have fixed it. |
I'm pretty sure it was using the |
PR summary
This PR implements the use of Lib3h configuration in core, and stubs out the ability to choose either lib3h or n3h as the p2p networking engine. See: lib3h:#43
Breaking Change: You must add
type="n3h"
for current config files to work. eg:e.g. current n3h based configurations need to look something like like:
changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)