Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Trace signals conditionally exposed, take 2 #1428

Merged
merged 4 commits into from
May 24, 2019
Merged

Trace signals conditionally exposed, take 2 #1428

merged 4 commits into from
May 24, 2019

Conversation

maackle
Copy link
Collaborator

@maackle maackle commented May 23, 2019

PR summary

Redo of #1378

  • Rename Signal::Internal to Signal::Trace
  • Add expose_trace_signals bool to Configuration, if false then Trace signals will never be emitted over any interface
  • Set expose_trace_signals to true for nodejs conductor config

The first commit is noisy, it's just the sweeping rename to Trace. Look at the second commit for the actual filtering logic

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

@maackle maackle mentioned this pull request May 23, 2019
2 tasks
@zippy zippy merged commit 2bfdf91 into develop May 24, 2019
@zippy zippy deleted the trace-signals-2 branch October 4, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants