Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Trace signals conditionally exposed #1378

Closed
wants to merge 3 commits into from

Conversation

maackle
Copy link
Collaborator

@maackle maackle commented May 2, 2019

PR summary

  • Rename Signal::Internal to Signal::Trace
  • Add expose_trace_signals bool to Configuration, if false then Trace signals will never be emitted over any interface
  • Set expose_trace_signals to true for nodejs conductor config

The first commit is noisy, it's just the sweeping rename to Trace. Look at the second commit for the actual filtering logic

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

@maackle maackle mentioned this pull request May 2, 2019
2 tasks
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but tests broken and need to be updated.

@zippy
Copy link
Member

zippy commented May 23, 2019

Hey @maackle what's the scoop with this PR, should we be moving it forward?

@maackle
Copy link
Collaborator Author

maackle commented May 23, 2019

I redid this one as #1428 since my first attempt at find-and-replace was overzealous.

@maackle maackle closed this May 23, 2019
@zippy zippy deleted the trace-signals-conditionally-exposed branch October 4, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants