This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-rust into 2019-04-30-nix-default
thedavidmeister
changed the title
WIP: add default nix for dist builds
add default nix for dist builds
May 1, 2019
thedavidmeister
requested review from
philipbeadle,
duffybelfield,
zippy,
samrose and
dhtnetwork
May 1, 2019 10:45
Reviewed/Passed with flying colors! Green all the way. |
dhtnetwork
reviewed
May 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the steps outlined:
- Read the instructions.
- Steps completed
install nix tooling on mac/linux
- curl https://nixos.org/nix/install | sh
- Added To ensure that the necessary environment
variables are set, please add the line
. /Users/signal/.nix-profile/etc/profile.d/nix.sh - nix-env -f https://bit.ly/2DG8SW9 -iA hc holochain
- completed the install and uninstall process twice.
Would be good to follow this up with updates to the Quick Start Guide, providing examples for both |
philipbeadle
approved these changes
May 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love using nix
zippy
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adds a
default.nix
file that includes only the binaries.Facilitates pointing
nix-env
straight at a tarball if all you want is the binaries.Ignores all of the dependencies!
I'm chasing up a vanity URL from @duffybelfield
The "easy install" for binaries would look like this:
How does this work?
nix-shell
andnix-env
(and others) on mac/linuxnix-env
at a URL will look for a tarball, unpack it and look fordefault.nix
https://holochain.love
(will) points tohttps://github.com/holochain/holochain-rust/archive/master.tar.gz
default.nix
(added in this PR) exposes thehc
andholochain
binary derivations fromholonix
-i
flag tellsnix-env
to "install"-A
flag tellsnix-env
the names of the derivations to be installednix-env
copies the output of thehc
andholochain
derivations into the user's home directory (just the binaries)hc
andholochain
end up in~/.nix-profile/bin
and then later... to upgrade...
# upgrade derivations nix-env -f https://holochain.love -uA hc holochain
at least i think this works 🤔
i guess we will find out!!!
finally, to uninstall...
# uninstall binaries nix-env -e hc holochain
to track
develop
rather thanmaster
we havehttps://holochain.love/nightly
as welltesting/benchmarking notes
Example of a round trip (installing and uninstalling):
Currently
https://bit.ly/2DG8SW9
points tohttps://github.com/holochain/holochain-rust/archive/675685ae62392805d95da0a961d8a1d5d32a80de.tar.gz
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
Please check one of the following, relating to the CHANGELOG
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)