Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Crypto Keystore HDK functions #1148

Merged
merged 32 commits into from
Mar 27, 2019
Merged

Crypto Keystore HDK functions #1148

merged 32 commits into from
Mar 27, 2019

Conversation

lucksus
Copy link
Collaborator

@lucksus lucksus commented Mar 21, 2019

  • I have added a summary of my changes to the changelog
    adds new hdk functions for accessing the keystore:
    hc_keystore_list,
    hc_keystore_new_random,
    hc_keystore_derive_seed,
    hc_keystore_derive_key,
    hc_keystore_sign,

SoA context

Screenshot 2019-03-26 at 09 49 31

@lucksus lucksus changed the base branch from develop to crypto-conductor-1 March 21, 2019 16:28
@zippy zippy changed the title WIP: Crypto Keystor HDK functions WIP: Crypto Keystore HDK functions Mar 21, 2019
@zippy zippy changed the base branch from crypto-conductor-1 to develop March 22, 2019 17:15
@zippy zippy changed the title WIP: Crypto Keystore HDK functions Crypto Keystore HDK functions Mar 26, 2019
@zippy zippy requested review from zo-el and neonphog March 26, 2019 02:58
Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Collaborator

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs are too dense for anyone outside the org to gather much meaning from, but I don't think that's a big priority right now. The only thing that might feel good to add to them is a note like "This is advanced material, and more detail will be added to simplify usage of this functionality"

Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zippy zippy merged commit d1d402b into develop Mar 27, 2019
@zippy zippy deleted the crypto-hdk branch July 5, 2019 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants