Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

added new format for json rpc call into conductor #1090

Merged
merged 11 commits into from
Mar 8, 2019

Conversation

zippy
Copy link
Member

@zippy zippy commented Mar 6, 2019

  • I have added a summary of my changes to the changelog

Adds a call route to the json rpc for the conductor for making zome calls.

The old way will still work, but is marked as deprecated, and will be removed in updates in the near future.

This means that instead of using

{"jsonrpc": "2.0", "id": "0", "method": "instance_id/zome/function", "params": {}}

to do the same thing, you would use

{
  "jsonrpc":  "2.0", 
  "id":  "0",
  "method":  "call",
  "params": {
     "instance_id" : "test-instance-1",
     "zome" : "greeter",
     "function" : "hello",
     "params": {}
  }
}

@zippy zippy added the review label Mar 6, 2019
Copy link
Collaborator

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small renaming request. And then the slightly larger discussion about id vs instance_id, but I would approve after disambiguating instances_map

conductor_api/src/interface.rs Outdated Show resolved Hide resolved
@zippy zippy requested a review from maackle March 8, 2019 02:00
@zippy zippy merged commit e28e7d9 into develop Mar 8, 2019
@zippy zippy removed the review label Mar 8, 2019
@zippy zippy deleted the conductor-unified-call branch July 5, 2019 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants