This repository has been archived by the owner on May 11, 2021. It is now read-only.
added new format for json rpc call #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JettTech
requested review from
maackle,
lucksus and
willemolding
and removed request for
maackle and
lucksus
There was a problem hiding this comment.
please see #6
The way you have implemented it here means it will be impossible to call conductor admin functions!
|
Ah! Nice. #6 is a clean update ...and I agree, we do need a different structure for admin calls. Can we please merge this into master/publish these changes within the current npm module? I am currently getting logging errors due to this call structure change. |
|
Done, @holochain/hc-web-client is now at 0.1.3 with new call style |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated json rpc call method to be a static reference to "call," as per changes in PR #1090.