Nma notification.pl #252
Closed
Nma notification.pl #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INSTEON lights are treated differently in the web interface versus X10 lights, for example: they get different icons, and cannot be dimmed or brightened. This patch does the following: - Use the same light icons for INSTEON lights that are used for X10 lights. - Allow dimming/brightening of INSTEON lights by clicking on the left or right side of the icon in the web interface (only dimmable light, of course). - Fix a logic error that prevents disabling the button image cache. Ran into this while creating new icons for my web interface. - As an experimental "feature", and a small delay to try to give MH a chance to receive the new state of an INSTEON device changed through the web interface. This will allow the correct state to be displayed when the web page renders again. Disabled by default since it's just a hack (though it works good enough for me). Comments welcome.
Removed debug flag override; was unable to effectively set debug from .ini or web interface Eliminated lowercase conversion of city name Modified forecast city search API call to use lowercase Modified forecast city match to ignore case Added additional debug logging for forecase city match
Fix issue hollie#224. WeatherBug - Mixed case city search corrections
…ailable Use weather_weatherbug.pl or internet_weather.pl as an alternative.
Fix issue hollie#227. Remove weather_aws.pl - sevrice is no longer available
Moved responsibility for Insteon states out of http_server.pl and into the Insteon objects themselves. (i.e. Insteon::DimmableLight) The existing code was not working with the new object model. This is an additional fix for Issue hollie#212. Open Issue: http_server.pl->button_action() probably needs to be modified so Insteon lights dim/brighten correctly. It doesn't look like is_dimable() was ever implemented for any MH object.
Flip order of on/off states to match new web object model Used the set_states() function rather than directly modifying data from the Generic_Item class. Eliminated the save/restore of the "states" array. I'm not sure what the original pupose was but saving/restoring prevents users from defining additional states in their ini file. Note that the current device "state" is still stored.
Changed each instance of this calcualtion to use 5/4 rounding prior to calling sprintf(). There is some issue between perl data types and the C sprintf() implementation. In this case perl will print 255 but sprintf will return fe. Some instances of this were previously fixed by adding check logic to force fe or 254 to 100%. I modified all the instances to be consistent.
Fix issue hollie#212 - Web can not dim/brighten Insteon lights
Modified to match recent changes to docs/download.pod Modified to make revision optional. (i.e. 3.0 R1). If revision is not present then don't print "revision unknown". Updated syntax to eliminate perl warnings
Fix issue hollie#232: fix automated version check
Generate_voice_commands in Insteon.pm now calls get_voice_cmds for each object. get_voice_cmds is written to be inherited and modified by higher level objects This allows for unique voice commands to be added to objects in their respective class files without messing with the base Insteon.pm file. This commit merely copied over the voice commands as they existed before with little to no changes in the voice command design. Fixes hollie#181
Moved update_flags routine to KeyPadLinc classes Added unique voice commands
Added a number of functions to track message details. Added functions to print message statistics to the log Added functions to reset the message statistics Added 2 voice commands: - print message statistics - prints details on all devices to the log - reset message statistics - resets the message statistics to 0 for all devices
If inode==0 then we are probably on windows, so use abs_path to compare the two paths and see if they are the same. I don't have windows so hopefully this works. Fixes hollie#234
Conflicts: lib/Insteon/BaseInsteon.pm
Conflicts: lib/Insteon/BaseInsteon.pm
Finish processing each device before proceeding onto the next device.
Much more user friendly and descriptice name.
Get rid of old devcat type entries and related ping timer that is no longer used
Reintroduced method to request devcat that was previously called ping and overwritten by a real ping command. New method to request devcat is called get_devcat(). - Once devcat is obtained, it is saved through reboots and can be retreived with devcat() routine - Now also saves firmware which can be retrieved with firmware() routine We do not currently use the devcat values, but I could certainly see using it in the future.
Insteon: Per Device Min/Max Hops Setting
Conflicts: lib/Insteon/BaseInsteon.pm
Insteon: Set Send Timeout on a Per Device Basis
…perties Moved to the more appropriate DimmableLight class
- Added necessary messages. - Relocated definition of extended_get_set to BaseObject as multiple objects use this - Added some better descriptions of the functions
…rt to update_flags - Update flags belongs in the Keypadlinc class as it only works on these devices - Condensed the set routine from Keypadlinc and KeypadlincRelay into Keypadlinc - Added I2 support to update_flags - - In order to support the old version of update_flags, the manner in which the routine works is a little odd as users have to pass a hexadecimal flag to the routine. This could obviously be changed or supplemented in the future.
Insteon: Redesign Voice Command Creation
Fix Bug found by Bill Dripps
Add On Off Command to PLM Scenes
Insteon: Detailed Tracking and Reporting of Statistics Related to Message
Conflicts: lib/Insteon/BaseInsteon.pm lib/Insteon/Lighting.pm
Add Support for Update_Flags and Update_OnLevel/RampRate for I2 Devices
Conflicts: lib/Insteon/BaseInsteon.pm
Insteon Diagnostics
Fix bug identified by @JaredF
Insteon_Diags: Make Sure Setby is an Object
|
Invalid pull request against stable. Was fixed in #253, closing this invalid request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.