Insteon: Redesign Voice Command Creation #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate_voice_commands in Insteon.pm now calls get_voice_cmds for each object. get_voice_cmds is written to be inherited and modified by higher level objects This allows for unique voice commands to be added to objects in their respective class files without messing with the base Insteon.pm file. This commit merely copied over the voice commands as they existed before with little to no changes in the voice command design. Fixes hollie#181
Moved update_flags routine to KeyPadLinc classes Added unique voice commands
krkeegan
added a commit
that referenced
this pull request
Jul 31, 2013
Insteon: Redesign Voice Command Creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design is much more pleasurable to work with and much less confusing. All prior voice commands were kept, although a few of them have been broken for a little while.
This fixes issue #181