Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insteon: Add Failure Callbacks to Add, Delete and Update Links #73

Closed
krkeegan opened this issue Feb 11, 2013 · 0 comments
Closed

Insteon: Add Failure Callbacks to Add, Delete and Update Links #73

krkeegan opened this issue Feb 11, 2013 · 0 comments

Comments

@krkeegan
Copy link
Collaborator

Currently if an add, delete or update link fails, the failure is called out in the print log, but only at the time of the error. As a result, if a failure occurs during a sync_links or delete_orphans call to the PLM the failures will often be buried within the long print log output. These failure can easily be missed.

As a solution, the errors should be gathered and displayed at the end of the batch process similar to how they are displayed for scan_all_links. Some of the foundational logic for this already exists for sync links, the failure call back just needs to be passed down through the subroutine calls.

Delete_Orphans does not contain any logic for this and would need to be supplemented.

krkeegan added a commit to krkeegan/misterhouse that referenced this issue Oct 23, 2013
This enables the same feature that has been available in the scan_all_links function.  If an error occurs while attempting to sync_all_links, MH now recovers from the error, and continues to process the remainin objects in Sync_All.  At the conclusion of the Sync_All routine a message is displayed identifying the failed objects.

Partial Fix hollie#73
krkeegan added a commit to krkeegan/misterhouse that referenced this issue Oct 23, 2013
Adds a similar functionality to what has been in scan all links.  If a failure occurs on a device while running delte orphans, MH now recovers and continues to process the rest of the delete queue.  At the conclusion of the queue, the failed object is reported.

Fixes hollie#82 hollie#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant