Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOAA website changes broke lib/site/Geo/WeatherNOAA.pm and get_weather (see issue #631) #662

Open
ghost opened this issue Jan 11, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 11, 2017

Note that the NOAA has shutdown that (new, different, fixed) site, so any fixes based on that site are again broken:
"The site which previously served that data has been shut down. Here is a link where you can get similar data: http://forecast.weather.gov/product.php?site=RAH&issuedby=RAH&product=RWR&format=txt&version=1&glossary=0. Let me know if you have any questions."

@ghost
Copy link
Author

ghost commented Jan 11, 2017

I thought this was (last) resolved in #631, but when looking at the code tree WeatherNOAA.pm hasn't been changed/updated? I just updated the URLs (based on the earlier code discussed in #631) , and it's back to working. I'm not familiar with GitHub, or Perl/MH Formatting standards, so here you go.

WeatherNOAA.zip

@hollie
Copy link
Owner

hollie commented Jan 11, 2017

Hey @ricks03

yes it was fixed, please see https://github.com/hollie/misterhouse/tree/master/lib/site/Geo

You probably checked the file in the stable branch of the repo, and that one does not contain the change yet.

All development takes place in the 'master' branch. There the file was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant