get_first_empty_address should return 0 if no addr #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sub add_link expects get_first_empty_address to return 0 if no empty address is found. This will prevent trying to add an aldb record to the FFFFFFFFFFFFFFF8 address which clearly doesn't exist. Instead the user will now get a nice error advising them to scan the link table before trying to sync links. It appears that something about Marc Merlin or my changes have some difference in the line endings. Not sure why the additional lines are listed as changed.
|
Yeah, the whitespace thing is annoying but the patch looks reasonable, thanks. |
marcmerlin
added a commit
that referenced
this pull request
Jan 19, 2013
get_first_empty_address should return 0 if no addr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sub add_link expects get_first_empty_address to return 0 if no empty address is found.
This will prevent trying to add an aldb record to the FFFFFFFFFFFFFFF8 address which clearly doesn't exist. Instead the user will now get a nice error advising them to scan the link table before trying to sync links.
It appears that something about Marc Merlin or my changes have some difference in the line endings. Not sure why the additional lines 1222-24 1244-45 are listed as changed.