Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fails on node 14 #136

Closed
ariwbolton opened this issue Sep 18, 2020 · 6 comments
Closed

Install fails on node 14 #136

ariwbolton opened this issue Sep 18, 2020 · 6 comments

Comments

@ariwbolton
Copy link

I tried to install v2.4.9 and v3.2.0 using node 14.11.0, but I'm getting this error for both versions during npm install sodium-native:

> [email protected] install /Users/me/Documents/tmp/node_modules/other-package/node_modules/sodium-native
> node-gyp-build "node preinstall.js" "node postinstall.js"

libtool is required, but wasn't found on this system
./configure: line 5: ./configure: No such file or directory
/Users/me/Documents/tmp/node_modules/other-package/node_modules/sodium-native/preinstall.js:119
    if (err) throw err
             ^

Error: ./configure exited with 127
    at ChildProcess.<anonymous> (/Users/ari/Documents/tmp/node_modules/other-package/node_modules/sodium-native/preinstall.js:149:25)
    at ChildProcess.emit (events.js:314:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-gyp-build "node preinstall.js" "node postinstall.js"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/me/.npm/_logs/2020-09-18T00_16_58_814Z-debug.log

Installing both versions using node 12 works fine; I suspect support for node 14 just hasn't been added yet. (Unless the intent is for users to now install libtool manually before installing sodium-native -- I haven't tried that, but I'm hoping to avoid that if possible)

@mixmix
Copy link
Contributor

mixmix commented May 24, 2021

from memory you might need https://www.npmjs.com/package/node-gyp installed globally, and if you follow the install of that closely I think you might find yourself installing libtool??

@mixmix
Copy link
Contributor

mixmix commented May 24, 2021

oh also note I think you only need these build tools in place if it couldn't find an existing prebuilt binary matching your system setup. That might be why you didn't hit this in the past

@gre
Copy link

gre commented Jun 28, 2021

Should there be some prebuilds on sodium-native to solve this situation? Experiencing same issue

@mafintosh
Copy link
Contributor

There should be prebuilds and I run it daily (and many others as well on mac). Can you share a bit more about the system you are seeing failures on?

@gre
Copy link

gre commented Jun 28, 2021

System Mac OS Big Sur 11.4

uname -a
Darwin LMFR0019 20.5.0 Darwin Kernel Version 20.5.0: Sat May  8 05:10:33 PDT 2021; root:xnu-7195.121.3~9/RELEASE_X86_64 x86_64

node -v
v14.17.1

How I experience an issue: mostly through stellar-sdk, would it be because they use an outdate version then?

➜  foo yarn add stellar-sdk
yarn add v1.22.10
warning ../package.json: No license field
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
warning Error running install script for optional dependency: "/Users/grenaudeau/Desktop/foo/node_modules/sodium-native: Command failed.
Exit code: 1
Command: node-gyp-build \"node preinstall.js\" \"node postinstall.js\"
Arguments:
Directory: /Users/grenaudeau/Desktop/foo/node_modules/sodium-native
Output:
automake is required, but wasn't found on this system
./configure: line 5: ./configure: No such file or directory
/Users/grenaudeau/Desktop/foo/node_modules/sodium-native/preinstall.js:119
    if (err) throw err
             ^

Error: ./configure exited with 127
    at ChildProcess.<anonymous> (/Users/grenaudeau/Desktop/foo/node_modules/sodium-native/preinstall.js:149:25)
    at ChildProcess.emit (events.js:375:28)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)"
info This module is OPTIONAL, you can safely ignore this error
success Saved lockfile.
success Saved 32 new dependencies.
yarn list sodium-native
└─ [email protected]

if you confirm it's because it's outdated, i'll directly contact stellar-sdk team. Thanks.

@gre
Copy link

gre commented Jun 28, 2021

Ok nevermind, I think it's more on stellar-sdk side now. Sorry for noise. stellar/js-stellar-base#404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants