Fixes issues with lib name generation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where automatic library name generation is used, but part of the generated library name is hardcoded else- where. This resulted in the build failing on windows, because the hardcoded portion was not applicapable. Note that while this allows Linenoise to be installed on windows once again, it still does not work properly. This is because libs that get installed have their file names mangled, but I think the linenoise.dll file needs to have the same name? (some missing symbol error gets thrown). OpenSSL had this problem, which it works around with lib/OpenSSL/NativeLib.pm6
|
@ugexe Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where automatic library name generation is
used, but part of the generated library name is hardcoded else-
where. This resulted in the build failing on windows, because
the hardcoded portion was not applicapable.
Note that while this allows Linenoise to be installed on windows
once again, it still does not work properly. This is because libs
that get installed have their file names mangled, but I think the
linenoise.dll file needs to have the same name? (some missing
symbol error gets thrown). OpenSSL had this problem, which it works
around with lib/OpenSSL/NativeLib.pm6