Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clustering code from the pipeline. Trigger Clustering in the worker, as we do UMAP #30

Open
gerbeldo opened this issue Aug 29, 2023 · 0 comments

Comments

@gerbeldo
Copy link
Member

gerbeldo commented Aug 29, 2023

Background

Clustering code is both in the pipeline and the worker, completely duplicated (tests included).

Currently, the first time clustering is calculated it is done in the pipeline, and that is what is shown to users. If a user changes a clustering parameter, a work request is triggered. And from then on, clustering is always performed in the worker.

@kafkasl has implemented a mechanism to trigger a work request for the UMAP and marker heatmap automatically after the pipeline finishes. This could be extended to clustering, removing the need for duplicated code (and a lot simpler than previously proposed solutions, like an R package with code for clustering to be imported by both the pipeline and worker).

goal

  • Trigger a work request for clustering automatically at the end of the pipeline
  • remove clustering code and tests from the pipeline.
@gerbeldo gerbeldo converted this from a draft issue Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant