Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check message type if BackOff #552

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

alexvpickering
Copy link
Contributor

Background

sns_message_payload["MessageAttributes"]["type"]["Value"] doesn't exist when the message is "BackOff":

image

This bug causes worker and pipeline pods are not shut down after exiting. As a result, when a user returns to an experiment after a time of inactivity, a new worker pod will not be assigned and they won't be able to get new results. Persistent pods will also run up costs.

Link to issue

Link to staging deployment URL

Links to any Pull Requests related to this

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with cellenics experiment pull)
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/hms-dbmi-cellenics/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/hms-dbmi-cellenics/cellenics-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@alexvpickering alexvpickering temporarily deployed to HMS August 4, 2023 18:12 — with GitHub Actions Inactive
@alexvpickering alexvpickering temporarily deployed to HMS August 4, 2023 18:13 — with GitHub Actions Inactive
@alexvpickering alexvpickering merged commit d3364b1 into master Aug 4, 2023
@alexvpickering alexvpickering deleted the fix-backoff-lambda branch August 4, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants