Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-1835] Implement samples PATCH for api v2 #334

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Apr 14, 2022

Description

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-1835

https://ui-martinfosco-ui686-api334.scp-staging.biomage.net/

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

hms-dbmi-cellenics/ui#686

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@cosa65 cosa65 changed the title Implement samples PATCH for api v2 [BIOMAGE-1835] Implement samples PATCH for api v2 Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #334 (483ee59) into master (80f0fac) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   83.87%   83.91%   +0.04%     
==========================================
  Files         126      126              
  Lines        3472     3482      +10     
  Branches      391      391              
==========================================
+ Hits         2912     2922      +10     
  Misses        511      511              
  Partials       49       49              
Impacted Files Coverage Δ
src/api.v2/controllers/experimentController.js 100.00% <100.00%> (ø)
src/api.v2/controllers/sampleController.js 100.00% <100.00%> (ø)
src/api.v2/routes/sample.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f0fac...483ee59. Read the comment docs.

@cosa65 cosa65 merged commit 3f0090c into master Apr 19, 2022
@cosa65 cosa65 deleted the 1835-samples-patch-api-v2 branch April 19, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants