Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi #113

Open
SBJgamer opened this issue May 19, 2021 · 4 comments
Open

Hi #113

SBJgamer opened this issue May 19, 2021 · 4 comments

Comments

@SBJgamer
Copy link

Hi im new on github i need 5 star only can you help me for complete my task

@1819981451
Copy link

1819981451 commented Jul 12, 2021

The following code contains the reason to Go to Next difference (F7) bug and have corresponding comments
The following code is in min/VS/Editor/editor.main.js

      class N extends c.EditorAction {
            constructor() {
                super({
                    id: "editor.action.diffReview.next",
                    label: i.localize(10, null),
                    alias: "Go to Next Difference",
                    precondition: v.ContextKeyExpr.has("isInDiffEditor"),
                    kbOpts: {kbExpr: null, primary: 65, weight: 100}
                })
            }

            run(e, t) {
                const i = M(e);//Because M(e) return null, i = null
                i && i.diffReviewNext()//Because i = null, i.diffreviewnext() will not be executed
            }
        }
        
        function M(e) {
            const t = e.get(h.ICodeEditorService), i = t.listDiffEditors(), n = t.getActiveCodeEditor();//n=null
            if (!n) return null;//In JavaScript ! Null is true, so M(e) also return null
            for (let e = 0, t = i.length; e < t; e++) {
                const t = i[e]
                ;
                if (t.getModifiedEditor().getId() === n.getId() || t.getOriginalEditor().getId() === n.getId()) return t
            }
            return null
        }
        
         class s extends o.CodeEditorServiceImpl {
            getActiveCodeEditor() {
                return null
            }
                ...
            }

@juaniscoding
Copy link

help you with what??

@SiweiZhong
Copy link

SiweiZhong commented Dec 1, 2023 via email

@huangfuyixiao
Copy link

huangfuyixiao commented Dec 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants