List appears clipped at the top

[ianh]

See attached screenshot. I believe (according to the output of top -ocpu) that this top sparkline is for WindowServer.

[hmarr]

Thanks for reporting. Which version of macOS are you using? I've only been able to test it on Catalina so far.

[ianh]

Ah yeah, it's Big Sur 11.2.2 (20D80). I looked at it in Xcode and it does look like the VStack is somehow larger than the ContentView that contains it.

[ianh]

Wrapping everything in a scroll view fixes the issue and looks nice too. I created a pull request at #8 if you're interested!

[hmarr]

Thanks for looking into this! Good to know that the scroll view fixes it. I think I'd rather avoid scrolling if possible, given that the 20 items should all easily fit in the space available.

I wonder whether wrapping the VStack in anything else (List, View, etc) helps the situation. The two other things that come to mind are adjusting the padding on the VStack, and changing the popover's contentSize.

If you have a chance to try those out and they do the trick, please do submit a PR! But no pressure 😄

Additionally, I noticed the numbers on the right look a bit smaller than the process names on the left. I'm not sure why that's happening for you – the other Big Sur screenshot I've seen doesn't seem to exhibit that behaviour.

[ianh]

Sounds good, thanks for taking a look. It seems like changing the contentSize of the popover so its height matches its contents would be a good solution, but I can't figure out how to get the height information out of SwiftUI.

[jlledo]

I've gone ahead and implemented the fix @ianh suggested in PR #10, hard coded since the height can be statically decided. As I mentioned in the PR this introduces a bit of coupling, but I really can't think of any other fix.

Before settling on that I basically tested every combination of calling fixedSize(horizontal:vertical:) on the Views, but nothing seemed to work. Granted, I'm no SwiftUI expert so feel free to reject if you don't think it's appropriate.

[ianh]

Verified this is fixed for me in b37168e. Thanks!

[hmarr]

Great! I just published v0.3 which includes this fix. It's also available in the Homebrew tap.