Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PaintingEditor's onImageEditingComplete returns the previously "undo/undone" element instead of the latest drawing #239

Closed
darielkurt opened this issue Oct 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@darielkurt
Copy link

darielkurt commented Oct 11, 2024

Package Version

5.4.1

Flutter Version

3.24.0

Platforms

Android, iOS, Web

How to reproduce?

Hi, thanks for this awesome package. However, I encountered an issue with the PaintingEditor

I replicated this on Android and iOS when we used PaintingEditor.memory on our project. Checked on the demo website if it is actually an issue and it exists on the demo web app.

Steps:

Web

  1. Go to the demo website
  2. Click "Signature or Drawing"
  3. Click either "Signature" or "Drawing"
  4. Draw anything (ex. circle)
  5. Click "Undo"
  6. Draw anything again (ex. a line)
  7. Click the check button
  8. Notice that the result is the one drawn previously (the one you draw on Step 4 above, circle)

Logs (optional)

No response

Example code (optional)

No response

Device Model (optional)

No response

@darielkurt darielkurt added the bug Something isn't working label Oct 11, 2024
@hm21 hm21 closed this as completed in 54b4960 Oct 11, 2024
@hm21
Copy link
Owner

hm21 commented Oct 11, 2024

Thanks for reporting that issue with detailed reproduction steps. I've just released version 5.4.2, which should resolve it.

@darielkurt
Copy link
Author

Thanks for reporting that issue with detailed reproduction steps. I've just released version 5.4.2, which should resolve it.

Thank you for your quick response. I hope to contribute to this package someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants