Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

chore: adding more selective partner logic #86

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 28, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 28, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI
/sponsors SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 28, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI
/sponsors SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 28, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI
/sponsors SI FCP LCP TBT CLS PSI

@davidnuescheler
Copy link
Contributor Author

i think the content structure for this should be very different... i think the sponsors page should have a sponsors block with with all the content in there, instead of separate documents. i think this will make the authoring easier and the preview publish process more intuitive (as a bonus, it will also remove some network payload)

Copy link
Collaborator

@shsteimer shsteimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #87 for the next set of changes to make this easier in the future.

@shsteimer shsteimer merged commit 968b833 into main Mar 29, 2023
@shsteimer shsteimer deleted the partner-change branch March 29, 2023 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants