Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the variable names of qrs, pts are so misleading! #15

Open
cam1681 opened this issue Sep 23, 2020 · 0 comments
Open

the variable names of qrs, pts are so misleading! #15

cam1681 opened this issue Sep 23, 2020 · 0 comments

Comments

@cam1681
Copy link

cam1681 commented Sep 23, 2020

In the paper, the authors use q to denote query points and p to denote representation points. But in the code, qrs is used to represent representation points and pts for query points. The mess makes the code very hard for comprehension for a newer like me. Hope you can change the names or give some notation in README at least. Thanks, on the behalf of the possible dazed people. I worked it out for a whole day.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant